-
-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added testcases covering all major browsers, removed cypress & added playwright 🧪 #1481
Conversation
- removed cypress (still need to remove folders and update readme.md) - installed playwright - wrote first few tests (homepage)
- firefox and chrome added - completed homepage fully (need to convert to po still) - create npm/yarn e2e script
- removed cypress directory since all the tests are covered - converted homepage to pageobject - added ideaspage and also added po for it - fixed main readme file to adjust to playwright - added plays.spec to write more tests later
- removed cypress.yml and added pw yml - using list reporter instaed of line reporter - added full sets of tests
✅ Deploy Preview for reactplayio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! contributor, thank you for opening a Pull Request 🎉.
@reactplay/maintainers will review your submission soon and give you helpful feedback.
If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.
Signed-off-by: Mohat Shil <120472338+shilCode@users.noreply.github.com>
Signed-off-by: Mohat Shil <120472338+shilCode@users.noreply.github.com>
will check soon |
there are a few failed test cases & most of them have the same error.
|
Thanks @priyankarpal for reviewing the pr 🙂
so basically if here is a gif version of mentioned steps you can also use official playwright official extention to repro it in visual way however it might not provide reports properly. again thanks for looking into this 🙂 |
ok ok let me try this |
working 🚀 |
Description
Firstof all, love the work all of you are doing! I was trying to learn react and as a QA engineer myself the testing bit caught my eye (obiously) or atleast lack of robustness of it did. So in this pr I tried to write some critcal path e2e tests to contribute atleast something to react-play community. I wanted to write on top of the already present cypress test-cases however soon realized there aren't that much of tests so wanted to give capability of mutil-browser such as firefox and safari - thus added playwright and removed all cypress dependencies. Playwright is much better than cypress, there are millions of documents which will say that but I use both in my day to day work so it doesn't matter to me much but in this case I think playwright suits better. I made sure nothings breaks with this change and all the previous tests are covered as much as possible. In a future pull request I will try to add mobile capability
To view all the changes I made checkout my commit messages, but here are some big changes I made:
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
enhanced testing capabilities itself attaching html report
Checklist:
Screenshots or example output
playwright-report.zip