Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Auto update user readme #210

Merged
merged 2 commits into from
May 22, 2022

Conversation

naiknareshh
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Added feature request to automatically update user readme based on user inputs. no dependencies were added for this change.

Fixes #207

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented May 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview May 21, 2022 at 5:17AM (UTC)

@naiknareshh
Copy link
Contributor Author

This is Ready for Review

@koustov
Copy link
Member

koustov commented May 21, 2022

@naiknareshh can you share a screenshot of readme from newly created play?

@naiknareshh
Copy link
Contributor Author

Generated Readme File -

image

Preview -

image

@atapas
Copy link
Member

atapas commented May 21, 2022

Generated Readme File -

image

Preview -

image

@koustov let me know if any changes are required. Otherwise, it is LGTM

@atapas atapas requested review from atapas and koustov May 21, 2022 09:40
Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naiknareshh
Copy link
Contributor Author

Not sure why Merging is still blocked for this. let me know if I am missing something.

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atapas
Copy link
Member

atapas commented May 22, 2022

Not sure why Merging is still blocked for this. let me know if I am missing something.

Nope, nothing from your side. It is just the sequence we can get to PR to approve and merge. Good Work @naiknareshh

@atapas atapas merged commit ae292e5 into reactplay:main May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Automatically updating play readme based on user input
3 participants