Modified the play not found message with search term #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vasantisuthar is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Sachin-chaurasiya could you please review this one? |
atapas
requested changes
Aug 12, 2022
|
@vasantisuthar what's pending on this? |
Co-authored-by: Sachin Chaurasiya <sachinchaurasiyachotey87@gmail.com>
Co-authored-by: Sachin Chaurasiya <sachinchaurasiyachotey87@gmail.com>
Sachin-chaurasiya
previously approved these changes
Aug 23, 2022
koustov
requested changes
Aug 25, 2022
src/common/playlists/PlayList.jsx
Outdated
Comment on lines
36
to
39
| <p className='page-404-lead'>Play not found | ||
| {hasFilterQuery? " for matched filter criteria" : null} | ||
| {hasFilterQuery && searchTerm ? " and": null} | ||
| {searchTerm ? ` for ${searchTerm}` : null} |
There was a problem hiding this comment.
A tiny observation,
This is a little complex from the readability front. Can you simplify it? Something like creating a method for doing this job in a more readable way?
|
@vasantisuthar What's pending in this? |
|
Closing this PR as No Response for close to a couple of months. Please request to open if still working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: