ADD font face selection #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Font selection in the settings popup
Moby Dick with OpenDyslexic font
|
danielweck
reviewed
Jul 19, 2018
| @@ -10,6 +10,7 @@ | |||
| <script src="builds/single-bundle/readium-shared-js_all.js" type="text/javascript"></script> | |||
|
|
|||
| <script src="epubReadingSystem.js" type="text/javascript"></script> | |||
| <script src="font-faces/fonts.js" type="text/javascript"></script> | |||
There was a problem hiding this comment.
Is the font-faces/fonts.js file missing from this PR?
There was a problem hiding this comment.
Oh sorry, it is dynamically resolved (HTTP route): https://github.com/readium/SDKLauncher-Android/pull/145/files#diff-da5def91bcae4c49b677f23482bf2658R522
danielweck
reviewed
Jul 19, 2018
| // reader.html | ||
| if (mime.equals("application/xhtml+xml")) { | ||
| mime = "text/html"; | ||
| } | ||
|
|
There was a problem hiding this comment.
Ah! Tabulations vs. space characters! :)
There was a problem hiding this comment.
My apologies, I chose the wrong option on Android Studio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired from readium-js-viewer, this pull request add a spinner to the ViewerSettingsDialog to choose the font face.
4 choices are available :