Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request to update for supporting LCP #79

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

fasooDev6
Copy link

I send a pull request for SDKLanucher-Android for supporting LCP.

The following are summary for changed files:
ContainerList.java

  1. if(container == null)
    • If container is null, stop processing intent and show the error message
  2. class OpenBookOnThread extends Thread
    • We have changed the way of opening EPUB by processing in separate thread.
      Because LCP needs to popup pass-phrase dialog-box waiting user input in the Readium SDK, which does not work in the same thread.
  3. private void containerRegisterContentModules(Context context)
    • We added containerRegisterContentModules to invoke Drminitialize.
      If user wants to include the DRM feature into the Launcher, call this method before the opening container in the "OpenBookOnThread".

DrmInitialize.java

  • We created one blank method as DrmInitalize.
  • If user wants to include the DRM feature into the Launcher, It can be connected with DRM Initialize.

Please reper to
readium/SDKLauncher-iOS#68

};
// async!
popSdkErrorHandlerMessage(context, callback);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that there is a similar PR for the proposed above code change (nil container):
https://github.com/readium/SDKLauncher-Android/pull/76/files#diff-c50ac569905f558500aec3f615f04357

@rkwright
Copy link
Contributor

We'll need to review this in the context of the ongoing LCP integration work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants