Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Decorator API #186

Merged
merged 56 commits into from
Aug 20, 2021
Merged

Decorator API #186

merged 56 commits into from
Aug 20, 2021

Conversation

mickael-menu
Copy link
Member

@mickael-menu mickael-menu commented Jun 23, 2021 •
edited
Loading

See the specification of the Decorator API

Added

  • (alpha) Support for the Decorator API to draw user interface elements over a publication's content.
    • This can be used to render highlights over a text selection, for example.
    • For now, only the EPUB navigator implements DecorableNavigator. You can implement custom decoration styles with HTMLDecorationTemplate.

Notes

  • A GitHub action will lint the JavaScript code and check if the bundle is up to date.
  • A part of the Hypothesis repo was copied as-is. We'll discuss with them how to extract this code in a dedicated repo.

@mickael-menu mickael-menu force-pushed the feature/decorator branch 3 times, most recently from 5fc85d4 to 0e38385 Compare June 24, 2021 12:19
@mickael-menu mickael-menu mentioned this pull request Jul 6, 2021
Merged
mickael-menu added 20 commits July 6, 2021 16:11
@mickael-menu
Merge branch 'develop' of github.com:readium/r2-navigator-swift into …
1400cbb 
…feature/decorator
@mickael-menu
Merge branch 'feature/selectable' of github.com:readium/r2-navigator-…
3fbe709 
…swift into feature/decorator
@mickael-menu
Implement SelectableNavigator for EPUB
517fcfd
@mickael-menu
Fix underline, strikethrough and sidemarks
2e3c72c
@mickael-menu
Add documentation and remove some decoration styles
3289f3f
@mickael-menu
Derive the current selection from current locator
37b9d30
@mickael-menu
Handle decoration interactions
2bec9e0
@mickael-menu
Override default tap event when activating a decoration
a4615dc
@mickael-menu
Add activate state for highlight style
ed5a517
@mickael-menu
Last decorations take precedence for activation when overlapping
7b01530
@mickael-menu
Add comments
3dc8e2c
@mickael-menu
Merge branch 'develop' of github.com:readium/r2-navigator-swift into …
c0451c8 
…feature/decorator
@mickael-menu
Fix Carthage project specs
fa19571
@mickael-menu
Fix lint errors
b1ddd59
@mickael-menu
Check scripts are up to date
e33e286
@mickael-menu
Report point location when activating a decoration and fix coordinate…
04ed537 
…s for FXL
@mickael-menu
Refactor highlight and underline styles
13de1a7
@mickael-menu
Merge branch 'feature/decorator' of github.com:readium/r2-navigator-s…
dccf30f 
…wift into feature/decorator
@mickael-menu
Fix scrolling to a range or element
2d2c999
@mickael-menu
Merge branch 'develop' into feature/decorator
092afd9 
# Conflicts:
#	CHANGELOG.md
#	r2-navigator-swift.xcodeproj/.xcodegen
#	r2-navigator-swift/EPUB/EPUBSpreadView.swift
#	r2-navigator-swift/PDF/PDFNavigatorViewController.swift
@mickael-menu mickael-menu marked this pull request as ready for review August 13, 2021 08:54
@mickael-menu mickael-menu merged commit d9c7931 into develop Aug 20, 2021
@mickael-menu mickael-menu deleted the feature/decorator branch August 20, 2021 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mickael-menu