Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prefixed css-rules when resetting transform on showIFrame #136

Closed
wants to merge 1 commit into from

Conversation

kaarholt
Copy link

CSS vendor prefixes were added in hideIFrame (via ReadiumSDK.Helpers.CSSTransformString), but not removed in showIFrame.
This resulted in the iframe remaining 'invisible' even after showIframe.

@danielweck
Copy link
Member

Thank you Kristoffer, much appreciated.
I totally agree with you, and there is in fact an issue about harmonising how CSS prefix are handled, so that this kind of CSS property "toggle" bug does not occur. See: #135

@danielweck
Copy link
Member

@kaarholt PS: on what platform did you observe the "invisible iframe" bug?

@kaarholt
Copy link
Author

This was on mac, with latest Chrome canary build.
I didn’t test in more browsers since the reason for the bug seemed obvious.

The value for '-webkit-transform: ….' remained on the iframe while only the unprefixed ‘transform’ got reset to ‘none’.
Since the prefixed rule came AFTER the unprefixed rule in the style string, it became the actual rule that Chrome used.

@danielweck
Copy link
Member

Hello @kaarholt
I have merged a "complete" fix into develop: #137
Could you please confirm that it works on your end?
Many thanks!
PS: I tested on OSX, Safari, Chrome and WebView

@danielweck danielweck closed this Oct 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants