Log an error if we abort the request to ReadMe #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thestrabusiness
approved these changes
Aug 27, 2020
When something goes wrong in the middleware, we rescue and just return to the next middleware in the chain. This commit adds some logging in that case so that users can better understand why some requests aren't being submitted to the ReadMe API. This might be due to a bug in this middleware (in which case this error will allow users to create better bug reports), or it might be due to a malformed body (in which case surfacing that to the user is helpful).
djmango
pushed a commit
to djmango/metrics-sdks
that referenced
this pull request
Sep 19, 2023
Bumps [minimist](https://github.com/substack/minimist) from 0.0.8 to 1.2.5. **This update includes security fixes.** - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/0.0.8...1.2.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
When something goes wrong in the middleware, we rescue and just return
to the next middleware in the chain.
This commit adds some logging in that case so that users can better
understand why some requests aren't being submitted to the ReadMe API.
This might be due to a bug in this middleware (in which case this error
will allow users to create better bug reports), or it might be due to a
malformed body (in which case surfacing that to the user is helpful).
🧪 Testing
Create a rack app and set up the readme middleware with an allow/reject parameter config. Then make a request that has a content type of
application/jsonbut whose body is not JSON:Check your logs, you should see an error informing you why the request was not logged to ReadMe: