Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test): moving unit testing over to vitest #260

Merged
merged 5 commits into from
May 25, 2024
Merged

feat(test): moving unit testing over to vitest #260

merged 5 commits into from
May 25, 2024

Conversation

erunion
Copy link
Member

@erunion erunion commented May 24, 2024 •
edited
Loading

🧰 Changes

  • Moves all of our unit testing here over to Vitest.
  • Lays some initial groundwork for a TS rewrite.

@erunion erunion added the refactor Issues about tackling technical debt label May 24, 2024
darrenyong
darrenyong approved these changes May 24, 2024
View reviewed changes
Copy link

@darrenyong darrenyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just made sure the tests ran! 👍

@erunion erunion merged commit d43f6e5 into main May 25, 2024
5 checks passed
@erunion erunion deleted the feat/modernization branch May 25, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenyong darrenyong darrenyong approved these changes

@kanadgupta kanadgupta Awaiting requested review from kanadgupta

Assignees
No one assigned
Labels
refactor Issues about tackling technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erunion @darrenyong