-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump #739
chore(deps): bump #739
Conversation
@@ -1,4 +1,4 @@ | |||
/* eslint-disable @typescript-eslint/ban-ts-comment */ | |||
/* eslint-disable @typescript-eslint/ban-ts-comment, no-console */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some minor cleanup here
* @see {@link https://docs.github.com/en/actions/learn-github-actions/environment-variables#default-environment-variables} | ||
*/ | ||
export function isGHA() { | ||
return isCI() && ci.GITHUB_ACTIONS; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to add this isCI() &&
clause to avoid false positives in a GitHub Actions test runner environment to ensure we're explicitly testing code that's specific to GHA. A few tests in __tests__/lib/fetch.test.ts
started breaking when upgrading to jest@29.4
... honestly this kinda threw me off all afternoon and I'm a bit confused why they were passing in the first place 😵💫
@@ -1,5 +1,5 @@ | |||
import type { CommandOptions } from '../lib/baseCommand'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lint 🤔 per this thread I'm not sure if this is a bug or not (per import-js/eslint-plugin-import#2683) but I'm just gonna roll with this for now.
i'm so confused man wtf
🧰 Changes
Before:
After:
This PR also includes a few lint-related cleanup/fixes and fixes a few tests that broke when upgrading to
jest@29.4
(see #739 (comment))