Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EthicalAds: force ad mentioning "Coming soon" #319

Merged
merged 1 commit into from
May 24, 2024
Merged

EthicalAds: force ad mentioning "Coming soon" #319

merged 1 commit into from
May 24, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented May 23, 2024

Closes #318

@humitos humitos requested a review from a team as a code owner May 23, 2024 09:45
@humitos humitos requested review from agjohnson and ericholscher and removed request for a team and agjohnson May 23, 2024 09:46
ericholscher
ericholscher approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Would be cool if we could control this from a feature flag, but baby steps :)

@humitos
Copy link
Member Author

humitos commented May 23, 2024

We can release only the addons pretty quickly if we want to change the ad without doing a full deploy. It's pretty simple

@humitos humitos merged commit 2bbc6db into main May 24, 2024
4 checks passed
@humitos humitos deleted the humitos/ethicalad-force-ad branch May 24, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make a plan to ship house ads first to Addons users
2 participants
@humitos @ericholscher