-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sphinxext-opengraph #118
Conversation
The generated image link is wrong: |
66cb6d9
to
1295ec9
Compare
Some caveats:
|
I don't like how it looks 😄 What about using just the logo, https://docs.ops.verbthenouns.com/projects/guidelines/_downloads/ed58d5ce6820efcfb0aa0146ee561409/logo-dark.png Another option is to update the same image that you are using but with a bigger height (blank) so it scales properly. |
Yeah, me neither 😂 testing your proposal |
It's greatly improved. Although I still don't like the look of the oversized logo 😄 Based on this article the best image size should be 1200 x 630.
I can alter the image if there's an option to upload it somewhere. |
Super insightful article, thanks @nienn !
In the absence of a better option, I guess we can upload it to the blog itself? |
Sounds good to me! |
@nienn sent me a modified version of the logo, modified from the original SVG for a more appropriate aspect ratio (thanks!). However, as I added it as part of this PR, I won't be able to test it until it's merged. |
This is NOT a real test on opengraph.xyz. It's just a montage with a preview of what it should look like. The logo was altered from the official version by spreading the text over 3 lines and changing it's proportion relatively to the icon. |
It looks great! When someone submits an accepting ✔️ 🟢 review I will merge the pull request, and we can make further adjustments thereafter |
@nienn Looks great -- I'll let @agjohnson chime in as current owner of the brand/logo, but I'm guessing that might shift to you here before long ✨ Our official logos are here: https://read-the-docs-guidelines.readthedocs-hosted.com/ -- but we don't have one in that aspect ratio. |
Looks good! The wordmark doesn't lend great to being split up, with the italicized Two options that would preserve the wordmark/logo for this format would be logo or wordmark only, but in the correct ratio, or logo in the background (probably fade out a good deal) and the main, single line wordmark centered overlaying that. All seem like good options. |
Also, this image format would be great to include in guidelines repo. |
Moving the logo discussion over here: readthedocs/guidelines#1 So it won't keep blocking this PR! |
I get from the discussion that this is a good start, and that there will be possibly more iterations on readthedocs/guidelines#1, so I'll go ahead and merge this, so we can start testing how it looks like in real life. Thanks everyone! |
Just tested it, it works 💯 |
This should improve the appearance of our links when shared in social media. Close #108.