-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build updates! #188
Build updates! #188
Conversation
…intersphinx. Apply styles for ablog that aligns headers with post ul list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Not sure about the CSS changes, since it's not my topic, but they look 👍🏼
cc'ing @agjohnson just in case he wants to review it.
What this PR mainly changes is margins, but it also re-aligns "Recent posts" with contents below it, which I think is nicer for the eye. I've opened #191 to re-address margins. |
I went back to very old blog posts and they still look good: https://readthedocs-blog--188.org.readthedocs.build/new-theme-read-the-docs/ ...however, I found an issue with unorderd lists that are missing bullets. Probably a DOM change. Adding more styles... |
These are some good exercises for understanding what effort went into maintaining sphinx-theme-rtd 🥲 |
I've been clicking around on a lot of blog posts now and stopped noticing things that look wrong. So I think we're good to ship this. It's supporting docutils 0.17 btw. |
Just noting that we don't plan to continue using our blog here. Our blog will be contained in our website repository, so spending much time here fixing things up is not a priority. We don't have a timeframe, and need to consider if/how we port content: |
Ah yes, that's much better than the current blog. I wasn't aware. I'll wrap up the footnotes issue 👍 Love the issue description over in readthedocs/website#33 ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit d89c557.
This update also contains #169
Before:
After: