Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pydocstyle check that Black doesn't use #198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove pydocstyle check that Black doesn't use #198

wants to merge 1 commit into from

Conversation

ericholscher
Copy link
Member

I'm assuming we shouldn't have checks that conflict with Black,
so removing this.

@ericholscher
Remove pydocstyle check that Black doesn't use
aa00227 
I'm assuming we shouldn't have checks that conflict with Black,
so removing this.
@ericholscher ericholscher requested review from a team, davidfischer and stsewd February 10, 2024 00:17
@ericholscher ericholscher mentioned this pull request Feb 10, 2024
Merged
@humitos
Copy link
Member

humitos commented Feb 10, 2024

pydocstyle adds a blank line and the Black removes it? 🤣

@ericholscher
Copy link
Member Author

Yea, at least I couldn't figure out how to make it match. Our other code seems to follow the pydocstyle format, so it's possible I might have been doing something wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

@davidfischer davidfischer Awaiting requested review from davidfischer davidfischer was automatically assigned from readthedocs/core

@stsewd stsewd Awaiting requested review from stsewd stsewd was automatically assigned from readthedocs/core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericholscher @humitos