Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Upgrade to pyinvoke 2.2.0 #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hoyes
Copy link
Contributor

@hoyes hoyes commented Feb 29, 2024

pyinvoke 1.7.1 fails with Python 3.11 due to changes to inspect.getargspec in the standard library. This has been fixed in 2.2.0

A smoke test of inv docker.up and inv docker.down are successful and the changelog (https://www.pyinvoke.org/changelog.html) doesn't mention any breaking changes other than the Python version. 2.2.0 supports all currently maintained versions of Python.

pyinvoke 1.7.1 fails with Python 3.11 due to changes to
inspect.getargspec in the standard library. This has been fixed in 2.2.0

A smoke test of `inv docker.up` and `inv docker.down` are successful and
the changelog (https://www.pyinvoke.org/changelog.html) doesn't mention
any breaking changes other than the Python version. 2.2.0 supports all
currently maintained versions of Python.

Signed-off-by: Peter Hoyes <Peter.Hoyes@arm.com>
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I think we are not hitting this issue because we use Python 3.10. However, I suppose there shouldn't be a problem upgrading this dependency. We should do some QA around this using Py3.10 before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants