Rotate ads on a visibilitychange event #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the ad placement to rotate when the tab regains focus after losing it subject to the normal ad rotation conditions:
When a tab loses focus, we send the view time immediately. If that time is less than 30s, then the ad will not immediately rotate when the tab comes back into focus. However, the view time will begin counting again (although it will not send the view time again). If the tab loses/regains focus again and the view time is then 30+, the ad will rotate.
This PR also cleaned up the event listeners a little bit and was a little more defensive in terms of clearing listeners automatically during ad rotation.