Project: use zh-cn if the language code is the unsupported zh
#370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple and small fix for this issue. We should still decide what to do at the db level still. Closes #358
3 tasks
agjohnson
approved these changes
Jun 6, 2024
humitos
added a commit
that referenced
this pull request
Jul 9, 2024
We keep returning 500 on projects with `zh`. This another interation on this fix for now. Sentry https://read-the-docs.sentry.io/issues/5066249292/ Related #370
humitos
added a commit
that referenced
this pull request
Jul 11, 2024
* Project: use a custom template filter to avoid `zh` languages We keep returning 500 on projects with `zh`. This another interation on this fix for now. Sentry https://read-the-docs.sentry.io/issues/5066249292/ Related #370 * Lint automatically * Manual linting * Feedback from review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple and small fix for this issue.
We should still decide what to do at the db level still.
Closes #358