Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project: change copy for "Finish" button #434

Merged
merged 9 commits into from
Aug 12, 2024
Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented Jul 25, 2024

Idea we talked in the Book Club.

I'm opening the PR here to continue improving this idea.

Idea we talked in the Book Club.

I'm opening the PR here to continue improving this idea.
@humitos humitos self-assigned this Jul 25, 2024
@humitos humitos changed the title Add project: small update to the workflow Add project: change copy for "Finish" button Jul 25, 2024
Explain a little more what's expected in this step.
It doesn't change the structure of the page on purpose, just updates the message.
@humitos
Copy link
Member Author

humitos commented Aug 5, 2024

This is how it looks now.

Screenshot_2024-08-05_17-31-12

@humitos humitos marked this pull request as ready for review August 5, 2024 15:32
@humitos humitos requested a review from a team as a code owner August 5, 2024 15:32
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple copy suggestions.

readthedocsext/theme/templates/projects/import_base.html Outdated Show resolved Hide resolved
readthedocsext/theme/templates/projects/import_config.html Outdated Show resolved Hide resolved
readthedocsext/theme/templates/projects/import_config.html Outdated Show resolved Hide resolved
@humitos
Copy link
Member Author

humitos commented Aug 12, 2024

OK. I've updated this PR with the feedback received. I think we can move forward with this for now and come later to add the modal with more step by step instructions.

@humitos humitos merged commit 70387cf into main Aug 12, 2024
4 checks passed
@humitos humitos deleted the humitos/import-workflow branch August 12, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants