Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: removing a message causes unwanted unknown message notification #11482

Closed
agjohnson opened this issue Jul 18, 2024 · 1 comment · Fixed by #11542
Closed

Notifications: removing a message causes unwanted unknown message notification #11482

agjohnson opened this issue Jul 18, 2024 · 1 comment · Fixed by #11542
Assignees
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@agjohnson
Copy link
Contributor

I noticed that when removing a message in code, or altering the message id, that all of the old messages stored in the database but not dismissed are still emit to the user as an Unknown message.

To reproduce:

  • Add a notification to your user, like the new dashboard notification
  • Change the id of the notification in the database or delete the message in code
  • Reload and you should receive this notification:

image

We should probably just raise an internal error, not message the user in this scenario. Sending a message is unexpected.

@agjohnson agjohnson added Bug A bug Accepted Accepted issue on our roadmap labels Jul 18, 2024
@humitos
Copy link
Member

humitos commented Aug 6, 2024

On the user side, we should show nothing (no notification at all). On the application side, we should log a Sentry event/New Relic log. We can't raise an exception because the production DB could have old IDs that were deleted in code but they are still in the DB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants