Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification on duplicated builds #7177

Closed
humitos opened this issue Jun 10, 2020 · 5 comments · Fixed by #8918
Closed

Notification on duplicated builds #7177

humitos opened this issue Jun 10, 2020 · 5 comments · Fixed by #8918
Assignees
@humitos
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: replication Bug replication is required

Comments

@humitos
Copy link
Member

humitos commented Jun 10, 2020

We deployed #7123 recently.

Now, I started receiving email notifications about the build being duplicated.

Screenshot_2020-06-10_17-39-09

Build: https://readthedocs.org/projects/test-builds/builds/11228342/

I think we should not send these notifications to users.
@humitos humitos added the Improvement Minor improvement to code label Jun 10, 2020
@humitos humitos added the Accepted Accepted issue on our roadmap label Jun 30, 2020
@humitos
Copy link
Member Author

humitos commented Jul 16, 2020

Weird. I received only one notification and I haven't received anymore. I'm sure there were lot of duplicated builds recently and no notifications in my inbox.

@humitos humitos added the Needed: replication Bug replication is required label Jul 16, 2020
@humitos humitos self-assigned this Jan 27, 2022
@humitos
Copy link
Member Author

humitos commented Jan 27, 2022

Check if this is still present after #8815

@humitos humitos mentioned this issue Feb 3, 2022
Merged
@bmw
Copy link

bmw commented Feb 10, 2022

I recently started seeing this for all of my projects. It's pretty annoying because I'd like to be notified about build failures, but I'm getting notifications about duplicated builds on every commit.

I tried recreating my webhooks on GitHub but it didn't seem to help. It's not clear to me what's causing the duplicated build, although that seems to be a known problem #8015.

humitos added a commit that referenced this issue Feb 14, 2022
@humitos
Build: do not send notifications on known failed builds
eb5ea47 
We do not want to send notifications (email or webhook) for known exceptions:

- Duplicated build
- Project builds skipped

Closes #7177
@humitos humitos mentioned this issue Feb 14, 2022
Merged
@humitos
Copy link
Member Author

humitos commented Feb 16, 2022

We deploy a fix yesterday to avoid sending notifications on duplicated builds. @bmw could you confirm that the issue is fixed now? Thanks!

@bmw
Copy link

bmw commented Feb 17, 2022

It does seem to be fixed now. Thanks a lot for quickly resolving this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@humitos humitos

Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: replication Bug replication is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build: do not send notifications on known failed builds readthedocs/readthedocs.org
2 participants
@humitos @bmw