Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Refactor the build & build customization pages (Diátaxis) #10028

Merged
merged 6 commits into from
Feb 15, 2023

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 14, 2023

This mostly was just cleanup,
and didn't change the structure of these pages.

I do think we want to break out the examples into a seperate page in the future,
but I just wanted an initial refactor here..

Fixes #9575

This mostly was just cleanup,
and didn't change the structure of these pages.

I do think we want to break out the examples into a seperate page in the future,
but I just wanted an initial refactor here..

Fixes #9575
@ericholscher ericholscher requested review from a team as code owners February 14, 2023 22:25
@ericholscher ericholscher changed the base branch from main to diataxis/main February 14, 2023 22:25
@ericholscher ericholscher changed the title relabel build Refactor the build & build customization pages Feb 14, 2023
@ericholscher ericholscher removed request for a team and agjohnson February 14, 2023 22:26
@ericholscher ericholscher changed the title Refactor the build & build customization pages Docs: Refactor the build & build customization pages Feb 14, 2023
@benjaoming benjaoming changed the title Docs: Refactor the build & build customization pages Docs: Refactor the build & build customization pages (Diátaxis) Feb 14, 2023
Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really solid changes, great clarifications all-round.

Not seeing any blockers here, just have a bunch of suggestions.

docs/user/glossary.rst Show resolved Hide resolved
docs/user/build-customization.rst Outdated Show resolved Hide resolved
docs/user/build-customization.rst Outdated Show resolved Hide resolved
docs/user/build-customization.rst Show resolved Hide resolved
docs/user/build-customization.rst Outdated Show resolved Hide resolved
docs/user/builds.rst Outdated Show resolved Hide resolved
docs/user/integrations.rst Show resolved Hide resolved
docs/user/integrations.rst Outdated Show resolved Hide resolved
docs/user/integrations.rst Outdated Show resolved Hide resolved
docs/user/integrations.rst Outdated Show resolved Hide resolved
Co-authored-by: Benjamin Balder Bach <benjamin@readthedocs.org>
Base automatically changed from diataxis/main to main February 15, 2023 15:31
@benjaoming
Copy link
Contributor

@humitos there are no PR links in the issue description, is the GitHub action okay? :)

@benjaoming benjaoming merged commit 38fca65 into main Feb 15, 2023
@benjaoming benjaoming deleted the relabel-build branch February 15, 2023 18:27
@humitos
Copy link
Member

humitos commented Feb 16, 2023

@benjaoming not sure why it didn't work --the GHA ran properly at https://github.com/readthedocs/readthedocs.org/actions/runs/4178636907/jobs/7237662920

@benjaoming
Copy link
Contributor

Aaaah, it got edited out :)

image

no smoke, no fire!

@ericholscher
Copy link
Member Author

✨ Glad to have this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: update builds and build customization page
3 participants