Standardize error template paths

[agjohnson]

In trying to rework the templates for proxito, I found it quite confusing
keeping the dashboard and proxito templates separate. This separates proxito
specific errors into a separate path just for these templates, errors/proxito,
instead of using various paths and naming conventions for these files.

This makes it possible for the new dashboard to isolate proxito error templates
and to extend from a common proxito error base.

• Refs Pages: add documentation/user error pages ext-theme#304
• Requires Support new dashboard in proxito common#220

[agjohnson]

I was expecting this PR to fail miserably, but seems it is either somehow okay or we don't have enough test coverage 🤷

[agjohnson]

Hrm, seems the last remaining piece is whatever these failures are:

------------------------------ Captured log call -------------------------------
WARNING  django.request:log.py:241 I'm a Teapot: /projects/subproject/
____________________ RedirectTests.test_subproject_root_url ____________________

self = <readthedocs.proxito.tests.test_redirects.RedirectTests testMethod=test_subproject_root_url>

    def test_subproject_root_url(self):
        r = self.client.get(
            "/projects/subproject/",
            secure=True,
            headers={"host": "project.dev.readthedocs.io"},
        )
>       self.assertEqual(r.status_code, 302)
E       AssertionError: 418 != 302

readthedocs/proxito/tests/test_redirects.py:89: AssertionError

I'm a little confused by them right now. I can see why these tests could fail with the 418 status response, but I can't yet explain why.

[humitos]

I don't have the answer here, but it seems those tests are hitting the dummy_dashboard_urls instead of the documentation Proxito urls.

[humitos]

Maybe the order of the definition changed somehow? /projects/subproject/ should be caught by

readthedocs.org/readthedocs/proxito/urls.py

Line 144 in f941fc7

re_path(r"^(?P<path>.*)$", ServeDocs.as_view(), name="docs_detail"),

[humitos]

Yeap, that's the issue. This diff makes that test to pass again:

diff --git a/readthedocs/proxito/urls.py b/readthedocs/proxito/urls.py
index ba465b3bc..2f3d33b8c 100644
--- a/readthedocs/proxito/urls.py
+++ b/readthedocs/proxito/urls.py
@@ -212,9 +212,10 @@ debug_urls = [
 groups = [
     health_check_urls,
     proxied_urls,
-    dummy_dashboard_urls,
     core_urls,
     docs_urls,
+    # Dummy dashboard URLs are required to be defined at the end
+    dummy_dashboard_urls,
 ]
 
 if settings.SHOW_DEBUG_TOOLBAR:

[humitos]

Looks great! 💯

I left a comment with the solution for the test that we should include here as well.

[agjohnson]

Thanks for that! I figured it had to be something around the URL changes too, I ended my day before getting into debugging at all though.