-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addons: prepare Proxito and dashboard to enable them by default #11513
base: main
Are you sure you want to change the base?
Conversation
Prepare Proxito's code and dashboard to enable addons by default starting on October 7th, as planned: https://about.readthedocs.com/blog/2024/07/addons-by-default/ Note this code is temporary and can be deployed _before_ reaching that particular date. The idea is to remove this code once this behavior becomes the default. Related #11474
Makes sense. I do wonder if we keep the ability to disable Addons if someone wants, and then we don't inject them at all? I can see some folks wanting that, especially on Business. |
This is a good point. I would probably only allow this on Business. I think we don't want OSS project without addons. Currently, they can disable all the addons one by one, but we will still inject our JS and run our code -- even if we don't show any of them. I understand there would be specific cases where the customer doesn't want that, right? |
Yea, it seems useful to at least have the option to not inject anything, since that might be useful in a few different contexts. |
This reverts commit 235514a.
Keep the ability to let commercial users to disable Addons completely. This means that our Cloudflare working won't even inject them.
I updated this PR to keep the ability to disable addons on "for Business". We will require to create for project_slug in Project.objects.values_list("slug", flat=True):
AddonsConfig.objects.get_or_create(project__slug=project_slug) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.. I wonder about having the AddonsConfig.objects.get_or_create(project=project)
code run somewhere in the codebase on that day automatically? Putting it in the Addons middleware is probably too heavy, but could be an option so we don't need to remember to run this on the CLI manually?
He, this was my first option as well; but I revert it because of the same reason.
I can write a Celery task to be run on that specific date automatically. |
Hrm... it seems the |
So, on October 7th we need to do the following things in both platforms (also local development):
|
For now... I added a reminder in Slack at least 🙃 |
Prepare Proxito's code and dashboard to enable addons by default starting on October 7th, as planned:
https://about.readthedocs.com/blog/2024/07/addons-by-default/
Note this code is temporary and can be deployed before reaching that particular date. The idea is to remove this code once this behavior becomes the default.
Related #11474
Footnotes
we will eventually remove this header and always inject our files. ↩