Convert an IRI path to URI before setting as NGINX header

[humitos]

Filepath can contains non-ASCII characters, so we need to convert to a valid URI before setting it as X-Accel-Redirec NGINX header because only ASCII characters are supported.

References,

• https://docs.djangoproject.com/en/1.11/ref/unicode/#uri-and-iri-handling
• X-Accel-Redirect with non-ascii filenames benoitc/gunicorn#1448

Closes https://github.com/rtfd/readthedocs-corporate/issues/409

NOTE: I didn't test this locally because I don't have the setup needed (gunicorn + nginx) properly configured. So, we will need to be careful when deploying this into production.

One example of what this fixes is,

In [1]: from django.utils.encoding import iri_to_uri                                                                                                                                          

In [2]: iri_to_uri('camión.html')                                                                                                                                                             
Out[2]: 'cami%C3%B3n.html'

[humitos]

Test in py2.7 failed because git doesn't recognize --prune-tags :/

[stsewd]

@humitos ^ wrong PR I guess? 😆

[humitos]

Nope. It was failing, but I re-triggered the test and it passed 🤷‍♂️

[agjohnson]

Is it worth adding a test here? I assume we already have tests for the send file header that should pass, but if not, that would be good to verify before/after this patch.

[humitos]

Is it worth adding a test here?

Yes.

I assume we already have tests for the send file header that should pass

We did have tests, but of course none of them tested that Unicode was supported. I forget 100% to add a test here 😞

I just pushed a test for this and it's working 😄

[ericholscher]

Looks good. 👍