Preserve strings inside Literal type annotations #423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I really appreciate the work put into this extension. It's very easy to set up and to customize.
Currently, if one has a type annotation with
Literal
, the strings inside are treated as if they were forward references, rather than constant strings.Given this function:
The generated documentation is this:
Rather than what would be expected:
I changed
astroid_utils._resolve_annotation
to check if the subscript value isLiteral
and if so, return.as_string()
for constants such as strings and bytes. I also added a few tests and a news fragment.