Broken bumpversion rule touches package-lock.json

[benjaoming]

The package-lock.json has become invalid since 1b4263e

[agjohnson]

Could you expand on this issue? The package lock file is updated after an npm install

[agjohnson]

Ahh okay, more information here: bumpver replaces all instances of 1.0.0 (or whatever the string is) inside the package lock file. Clearly not what we want. My PR just updates the lock file, but bumpver will continue to do this.

[benjaoming]

Closing as a duplicate of #1117

[agjohnson]

That issue is different, it's because there is a bumpversion package and a bump2version package. We use a different project altogether now though. I'd say this issue is valid and can be reopened.

[agjohnson]

The fix here is just removing the rule for package-lock.json, it doesn't need to be updated on release.

[benjaoming]

Ack, thanks for paying attention 🙏

[agjohnson]

Also, opened up #1324, as we haven't used bumpversion/bump2version on other repos since testing it here. bumpver is a bit nicer and doesn't suffer from the confusion between bumpversion/bump2version 🙃

We can come back to that though, it's a sideways migration as far as the next release is concerned. The simple fix for now seems 👍

[benjaoming]

TODO: Make note of later Node errors with the version scheme from our package.json