Fix Nav Buttons Size #1067
Merged
Fix Nav Buttons Size #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Nav buttons to expand the menu are a bit small and do not match the link text. This makes the buttons match the size of the link text and deduplicates some of the style rules.
This reverts commit 4b324a9.
stsewd
reviewed
Mar 3, 2021
| @@ -70,8 +70,7 @@ html | |||
| margin-left: -1.2em | |||
| @extend .fa | |||
| @extend .fa-plus-square-o | |||
| font-size: .8em | |||
| line-height: 1.6em | |||
| line-height: 18px | |||
There was a problem hiding this comment.
is the change to px units needed to fix this?
There was a problem hiding this comment.
There was a problem hiding this comment.
In the future, we should work on using one unit system, bootstrap uses rem, so we will likely use that in the future.
stsewd
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Nav buttons to expand the menu are a bit small and do not match the link text. This makes the buttons match the size of the link text and deduplicates some of the style rules.
Before:
After:
