Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the dependencies declaration to specify test dependencies #1346

Closed
wants to merge 1 commit into from

Conversation

pelson
Copy link
Contributor

@pelson pelson commented Sep 28, 2022

Use the dependencies declaration to specify test dependencies, rather than embedding them in the tox.ini

cc @agjohnson following on from #1345 (comment) (which I reverted in that PR)

@stsewd
Copy link
Member

stsewd commented Sep 28, 2022

Just a note, some maintainers are packaging this theme for some distributions, and they include tests (so they also need to package the test dependencies), I wasn't able to find the conversation, but would be nice to not have maintainers package the readthedocs-sphinx-ext extension, since it's only used internally by RTD.

I think it probably makes sense to have those tests in https://github.com/readthedocs/readthedocs-sphinx-ext, or have them conditionally run or something.

@pelson
Copy link
Contributor Author

pelson commented Oct 4, 2022

I'll withdraw this one - it wasn't working with tox, and I don't know it well enough to figure out the magic incantation. Furthermore, it seems that the desired solution isn't to correctly document the dependency, but rather to remove that dependency from the project.

@pelson pelson closed this Oct 4, 2022
@pelson pelson deleted the test-deps-decl branch October 4, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants