treewide: Upgrade tokio to 1.32 #422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glittershark
changed the base branch from
main
to
I989a0f7b49d01d130ab0586da90c0546f4a62b61
readysetbot
force-pushed
the
Id45707e0f95ca0a76ea69952ea23e8c65f846983
branch
from
bc230a3
to
190f943
Compare
glittershark
changed the base branch from
I989a0f7b49d01d130ab0586da90c0546f4a62b61
to
main
readysetbot
force-pushed
the
Id45707e0f95ca0a76ea69952ea23e8c65f846983
branch
from
190f943
to
99ddf06
Compare
Fix (or configure around) all existing clj-kondo lints, and run clj-kondo in CI. Since it was unused, this deletes the test file (generated by `lein new`) entirely. If we want to do unit tests later we can add it back. Fixes: REA-3371 Change-Id: I0db591510f6692bbb5bd161073afad4d3ad0a2c3 Reviewed-on: https://gerrit.readyset.name/c/readyset/+/5830 Tested-by: Buildkite CI Reviewed-by: Ethan Donowitz <ethan@readyset.io>
Upgrade the version of tokio we depend on to version 1.32, to get the version with tokio-rs/tokio#5925, my fix for a performance issue in `tokio::sync::broadcast`. We use this to notify workers when channels are removed from the channel coordinator, so we want this fix to improve the performance of that process. Change-Id: Id45707e0f95ca0a76ea69952ea23e8c65f846983
readysetbot
force-pushed
the
Id45707e0f95ca0a76ea69952ea23e8c65f846983
branch
from
99ddf06
to
f83eda7
Compare
|
Merged as 09b705eeb29ebc2dc39dabb066ff4e115cce9df2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the version of tokio we depend on to version 1.32, to get the
version with tokio-rs/tokio#5925, my fix for a
performance issue in
tokio::sync::broadcast. We use this to notifyworkers when channels are removed from the channel coordinator, so we
want this fix to improve the performance of that process.