Range picker hydration #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 10, 2023 14:35
- Created a new hook: useIsMobile
- which executes on the client side
- Refactored DateRangePicker to a functional component so
it can use the new `useIsMobile` hook when mounting
- Removed the usage of isMobile layout helper that was trying
to access the window width directly on React hydration after
server render, which caused different rendered content issues.
- the new isMobile hook uses `useEffect` which fires after
mount, preventing hydration mismatches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new hook: useIsMobile
Refactored DateRangePicker to a functional component so
it can use the new
useIsMobilehook when mountingRemoved the usage of isMobile layout helper that was trying
to access the window width directly on React hydration after
server render, which caused content mismatch issues
useEffectwhich fires aftermount, preventing hydration mismatches