Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java module support #627

Closed
cowwoc opened this issue Jan 30, 2019 · 7 comments
Closed

Java module support #627

cowwoc opened this issue Jan 30, 2019 · 7 comments
Labels
enhancement

Comments

@cowwoc
Copy link

cowwoc commented Jan 30, 2019 •
edited
Loading

Are there any plans to add Java module support?

I am expecting module-info.java files or (at the very least) Automatic-Module-Name entries in MANIFEST.MF to help my own modular code depend on your library.
@mjpt777
Copy link
Contributor

mjpt777 commented Jan 30, 2019

We currently have no plans for adding module support. If your company was willing to sponsor the work or purchase support then we could look into it.

@cowwoc
Copy link
Author

cowwoc commented Jan 30, 2019

@mjpt777 What about just adding an Automatic-Module-Name to MANIFEST.MF? Surely that is easy/quick to do?

@mjpt777
Copy link
Contributor

mjpt777 commented Jan 30, 2019

Please send a PR for that then.

@cowwoc
Copy link
Author

cowwoc commented Jan 30, 2019

@mjpt777 Sure. What module names would you like?

@mjpt777
Copy link
Contributor

mjpt777 commented Jan 30, 2019

What do you see as the modules and then we can suggest suitable names?

@cowwoc
Copy link
Author

cowwoc commented Jan 30, 2019

@mjpt777 I'd break it down the same lines as https://search.maven.org/search?q=g:io.aeron

So your module names would probably be io.aeron.driver, io.aeron.cluster and so on.

mjpt777 added a commit that referenced this issue Feb 2, 2019
@mjpt777
[Java] Add Automatic-Module-Name. Issue #627.
bb2aae9
@mjpt777 mjpt777 closed this as completed Feb 5, 2019
@cowwoc
Copy link
Author

cowwoc commented Feb 6, 2019

Very cool. Thanks Martin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cowwoc @mjpt777