You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
By valid channel I mean that if in this unit test you replace the channel with either of the above, the test will still pass (but it fails if I use "aeron:ipc?term-length=2k" as a channel).
With this error tolerant parsing, the expected and intended behaviour of the system can easily differ significantly without any warning sign. E.g. if someone accidentally makes a channel of aeron:ipc|sparse=true instead of aeron:ipc?sparse=true, then they will get a non-sparse buffer, when their intention was obviously to get a sparse one.
It's not that hard to make a typo in one of the option names or arguments either. I managed to get production issue today because of one. I just would have preferred seeing an exception in the early development phase rather than seeing my prod system behave differently to what I intended.
The text was updated successfully, but these errors were encountered:
Tomius
changed the title
Validate aeron channel strings.
Better validation for aeron channel strings.
Mar 11, 2020
The following four aeron channels are treated as completely valid for creating a subscription or a publication:
By valid channel I mean that if in this unit test you replace the channel with either of the above, the test will still pass (but it fails if I use
"aeron:ipc?term-length=2k"
as a channel).With this error tolerant parsing, the expected and intended behaviour of the system can easily differ significantly without any warning sign. E.g. if someone accidentally makes a channel of
aeron:ipc|sparse=true
instead ofaeron:ipc?sparse=true
, then they will get a non-sparse buffer, when their intention was obviously to get a sparse one.It's not that hard to make a typo in one of the option names or arguments either. I managed to get production issue today because of one. I just would have preferred seeing an exception in the early development phase rather than seeing my prod system behave differently to what I intended.
The text was updated successfully, but these errors were encountered: