Merge pull request #113 from pjulien/no_io_exception

Remove IOException from signatures, cannot be thrown
real-logic · Nov 16, 2017 · e5b49bb · e5b49bb
2 parents 82efa96 + 1a884e4
commit e5b49bb
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 11 deletions.
diff --git a/agrona/src/main/java/org/agrona/io/DirectBufferInputStream.java b/agrona/src/main/java/org/agrona/io/DirectBufferInputStream.java
@@ -17,7 +17,6 @@
 
 import org.agrona.DirectBuffer;
 
-import java.io.IOException;
 import java.io.InputStream;
 
 /**
@@ -97,20 +96,20 @@ public boolean markSupported()
         return false;
     }
 
-    public int available() throws IOException
+    public int available()
     {
         return length - position;
     }
 
-    public long skip(final long n) throws IOException
+    public long skip(final long n)
     {
         final int skipped = (int)Math.min(n, available());
         position += skipped;
 
         return skipped;
     }
 
-    public int read() throws IOException
+    public int read()
     {
         int b = -1;
         if (position < length)
@@ -122,7 +121,7 @@ public int read() throws IOException
         return b;
     }
 
-    public int read(final byte[] dstBytes, final int dstOffset, final int length) throws IOException
+    public int read(final byte[] dstBytes, final int dstOffset, final int length)
     {
         int bytesRead = -1;
 
@@ -135,4 +134,8 @@ public int read(final byte[] dstBytes, final int dstOffset, final int length) th
 
         return bytesRead;
     }
+
+    public void close()
+    {
+    }
 }
diff --git a/agrona/src/main/java/org/agrona/io/DirectBufferOutputStream.java b/agrona/src/main/java/org/agrona/io/DirectBufferOutputStream.java
@@ -17,7 +17,6 @@
 
 import org.agrona.MutableDirectBuffer;
 
-import java.io.IOException;
 import java.io.OutputStream;
 
 /**
@@ -108,7 +107,7 @@ public int length()
      * @param b to be written.
      * @throws IllegalStateException if insufficient capacity remains in the buffer.
      */
-    public void write(final int b) throws IOException
+    public void write(final int b)
     {
         if (position == length)
         {
@@ -127,7 +126,7 @@ public void write(final int b) throws IOException
      * @param length    of the srcBytes to read.
      * @throws IllegalStateException if insufficient capacity remains in the buffer.
      */
-    public void write(final byte[] srcBytes, final int srcOffset, final int length) throws IOException
+    public void write(final byte[] srcBytes, final int srcOffset, final int length)
     {
         final long resultingOffset = position + ((long)length);
         if (resultingOffset >= this.length)
@@ -138,4 +137,8 @@ public void write(final byte[] srcBytes, final int srcOffset, final int length)
         buffer.putBytes(offset + position, srcBytes, srcOffset, length);
         position += length;
     }
+
+    public void close()
+    {
+    }
 }
diff --git a/agrona/src/main/java/org/agrona/io/ExpandableDirectBufferOutputStream.java b/agrona/src/main/java/org/agrona/io/ExpandableDirectBufferOutputStream.java
@@ -17,7 +17,6 @@
 
 import org.agrona.MutableDirectBuffer;
 
-import java.io.IOException;
 import java.io.OutputStream;
 import java.util.Objects;
 
@@ -108,7 +107,7 @@ public MutableDirectBuffer buffer()
      *
      * @param b to be written.
      */
-    public void write(final int b) throws IOException
+    public void write(final int b)
     {
         buffer.putByte(offset + position, (byte)b);
         ++position;
@@ -121,9 +120,13 @@ public void write(final int b) throws IOException
      * @param srcOffset at which to begin reading bytes from the srcBytes.
      * @param length    of the srcBytes to read.
      */
-    public void write(final byte[] srcBytes, final int srcOffset, final int length) throws IOException
+    public void write(final byte[] srcBytes, final int srcOffset, final int length)
     {
         buffer.putBytes(offset + position, srcBytes, srcOffset, length);
         position += length;
     }
+
+    public void close()
+    {
+    }
 }