Allow client code to control agent runner close timeout beahviour #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The retry close timeout can now be supplied as a parameter. An optional action can be supplied to be taken on each close timeout.
|
Hi, If you don't mind, this simple change allows client code to control the closing behaviour in a slightly more granular manner. It is fully backwards compatible (still has a no-arg close which will write the identical message in standard error). I use it to obtain a thread stack trace and log it with log4j2 so that once can see what the "slow to react" agent is doing... |
mjpt777
added a commit
that referenced
this pull request
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The retry close timeout can now be supplied as a parameter. An
optional action can be supplied to be taken on each close timeout.