DynamicPackageOutputManager and its implementation #266
Conversation
ratcashdev
force-pushed
the
feature/sbe-type-overrides
branch
from
28f1d52 to
da83f68
Compare
| public interface MultiPackageOutputManager extends OutputManager | ||
| { | ||
| /** | ||
| * Sets the current package name. |
There was a problem hiding this comment.
Needs to define the scope in which the package change applies.
| /** | ||
| * Extended version of the OutputManager allowing to set the java package. | ||
| */ | ||
| public interface MultiPackageOutputManager extends OutputManager |
There was a problem hiding this comment.
Is it really "multi"? More like "switchable" or something that indicates use.
There was a problem hiding this comment.
packages are used to group, organize or distinguish. In this sense the following comes to my mind:
(Code)OrganizingOutputManager, DynamicPackageOutputManager, GroupingOutputManager, PackageControlledOutputManager, SwitchablePackageOutputManager, SelectablePackageOutputManager, or NamedPackageOutputManager, PackageGovernedOutputManager, PackageAwareOutputManager
I think I prefer selectable, or dynamic or PackageGoverned...
There was a problem hiding this comment.
DynamicPackageOutputManger is probably one of the better.
agrona/src/main/java/org/agrona/generation/StringWriterOutputManager.java
Outdated
Show resolved
Hide resolved
agrona/src/main/java/org/agrona/generation/PackageGovernedOutputManager.java
Outdated
Show resolved
Hide resolved
ratcashdev
changed the title
|
@mjpt777 is there a way to reference the merged (snapshot) version of agrona from SBE's PR? Or should I just wait a couple of days till a release is published? |
This can only be done locally. |
As a preparation, and with the assumption that real-logic/simple-binary-encoding#904 will receive no major changes, I'd like to propose to merge this PR for the upcoming version of agrona.