Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XmlSchemaParser doesn't handle XML namespace #1

Closed
donmendelson opened this issue Nov 1, 2013 · 1 comment
Closed

XmlSchemaParser doesn't handle XML namespace #1

donmendelson opened this issue Nov 1, 2013 · 1 comment

Comments

@donmendelson
Copy link

We normally generate message schema with an XML namespace declaration for the SBE XML schema and prefix on the root element. However, the parser fails to parse it in that case. It does work if all namespaces are stripped out.

Example:
<sbe:messageSchema xmlns:sbe="http://www.fixprotocol.org/ns/simple/1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" package="MarketData" version="0" semanticVersion="FIX.5.0" description="Test dictionary" byteOrder="littleEndian" xsi:schemaLocation="http://www.fixprotocol.org/ns/simple/1.0/SimpleBinary1-0.xsd">

An issue with this is that the XSD is not actually accessible at the schemaLocation. However, removing that attribute does not resolve the problem. The parser should not depend on accessing the XSD via the internet.

@mjpt777
Copy link
Contributor

mjpt777 commented Nov 1, 2013

Removed awareness for xml namespacing from xml parsing. All namespaces should now be supported with the consequence that xinclude is no longer supported.

@mjpt777 mjpt777 closed this as completed Nov 1, 2013
odeheurles pushed a commit that referenced this issue Dec 6, 2013
…f manipulating buffer pointer directly and generate [Flags]enum for bitsets (choices/set). see issue #1 (AdaptiveConsulting#1)
adam-talos added a commit to adam-talos/simple-binary-encoding that referenced this issue Dec 18, 2022
real-logic#1: LibRsDef explicitly us crate:: to disambiguate from built in mods like bool
real-logic#2: Added acting_version field to Composite structs to fix compilation errors when using Composite structs.  This is an incomplete implementation because the parent doesn't pass the acting_version to the composite because you need to change the signature of wrap(parent, offset) to include the acting_version, so this version just ensures that if the acting_version isn't set on the composite, it disregards the version check.
real-logic#3: fixed primitiveArrayDecoder to return an empty array of the right size if less than version required.
suremarc pushed a commit to polygon-io/simple-binary-encoding that referenced this issue Jan 19, 2023
real-logic#1: LibRsDef explicitly us crate:: to disambiguate from built in mods like bool
real-logic#2: Added acting_version field to Composite structs to fix compilation errors when using Composite structs.  This is an incomplete implementation because the parent doesn't pass the acting_version to the composite because you need to change the signature of wrap(parent, offset) to include the acting_version, so this version just ensures that if the acting_version isn't set on the composite, it disregards the version check.
real-logic#3: fixed primitiveArrayDecoder to return an empty array of the right size if less than version required.
SeanKim pushed a commit to SeanKim/simple-binary-encoding that referenced this issue Feb 21, 2023
real-logic#1: LibRsDef explicitly us crate:: to disambiguate from built in mods like bool
real-logic#2: Added acting_version field to Composite structs to fix compilation errors when using Composite structs.  This is an incomplete implementation because the parent doesn't pass the acting_version to the composite because you need to change the signature of wrap(parent, offset) to include the acting_version, so this version just ensures that if the acting_version isn't set on the composite, it disregards the version check.
real-logic#3: fixed primitiveArrayDecoder to return an empty array of the right size if less than version required.
SeanKim pushed a commit to SeanKim/simple-binary-encoding that referenced this issue Mar 4, 2023
real-logic#1: LibRsDef explicitly us crate:: to disambiguate from built in mods like bool
real-logic#2: Added acting_version field to Composite structs to fix compilation errors when using Composite structs.  This is an incomplete implementation because the parent doesn't pass the acting_version to the composite because you need to change the signature of wrap(parent, offset) to include the acting_version, so this version just ensures that if the acting_version isn't set on the composite, it disregards the version check.
real-logic#3: fixed primitiveArrayDecoder to return an empty array of the right size if less than version required.
mjpt777 pushed a commit that referenced this issue Nov 1, 2023
…ults for enums (#952)

* Fixed several issues:
#1: LibRsDef explicitly us crate:: to disambiguate from built in mods like bool
#2: Added acting_version field to Composite structs to fix compilation errors when using Composite structs.  This is an incomplete implementation because the parent doesn't pass the acting_version to the composite because you need to change the signature of wrap(parent, offset) to include the acting_version, so this version just ensures that if the acting_version isn't set on the composite, it disregards the version check.
#3: fixed primitiveArrayDecoder to return an empty array of the right size if less than version required.

* [Rust] removed 'acting_version' field from SubGroup decoder

* [Rust] updated RustGenerator::generateEnum() to support derive "Default" instead of generating impl

* fixed formatting issue

* [Rust] updated how 'use declarations' are generated to prevent "ambiguous glob re-exports" warnings from rust compiler

---------

Co-authored-by: Adam Krieg <adam@talostrading.com>
Co-authored-by: Michael Ward <mward@drw.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants