Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ generator issue #470

Closed
ksergey opened this issue Jun 21, 2017 · 4 comments
Closed

C++ generator issue #470

ksergey opened this issue Jun 21, 2017 · 4 comments

Comments

@ksergey
Copy link
Contributor

ksergey commented Jun 21, 2017

Messages like below looks good for C++ generator

    <message name="Message1" id="1" blockLength="16">                                           
        <field name="field1" id="0" type="uint64"/>                                             
        <field name="field1" id="0" type="uint8"/>                                             
    </message>   

I don't know if it valid for SBE spec, but generated C++ code is not compilable

@mjpt777
Copy link
Contributor

mjpt777 commented Jun 22, 2017

This is valid. If you wanted to align the beginning of a repeating group or var data on a 16 byte boundary then you would do this. If blockLength is set then it must be greater than or equal to the sum of the field lengths given their offsets.

In what way does it not comply?

@ksergey
Copy link
Contributor Author

ksergey commented Jun 22, 2017

@mjpt777 I mean both fields has name "field1"

@mjpt777
Copy link
Contributor

mjpt777 commented Jun 22, 2017

Ah, that was not clear in the title of the issue. I'll investigate.

@mjpt777
Copy link
Contributor

mjpt777 commented Jun 22, 2017

I've pushed a change that validates message and field names are unique in context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants