Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpp generator #479

Closed
ksergey opened this issue Jul 14, 2017 · 8 comments
Closed

cpp generator #479

ksergey opened this issue Jul 14, 2017 · 8 comments

Comments

@ksergey
Copy link
Contributor

ksergey commented Jul 14, 2017

Why we need m_bufferLength and m_actingVersion private variables in generated class MessageHeader? This members not used inside MessageHeader.
@ksergey
Copy link
Contributor Author

ksergey commented Jul 14, 2017

Variable m_actingBlockLength in other classes also unused

@ksergey
Copy link
Contributor Author

ksergey commented Jul 14, 2017

I believe m_bufferLength should have public getter

@tmontgomery
Copy link
Contributor

MessageHeader is generated from a fixed flyweight. Those fields are used by other flyweights. Or I should say, might possibly be used depending on schema. m_bufferLength probably should have a getter. Agreed. Feel free to add that or I will eventually.

mjpt777 added a commit that referenced this issue Jul 15, 2017
@mjpt777
[c++] Provide a public accessor for buffer length in flyweights. Issue …
1d6bbbe 
…#479.
@ksergey
Copy link
Contributor Author

ksergey commented Jul 17, 2017

@tmontgomery Thank you! When you release new version?

@mjpt777
Copy link
Contributor

mjpt777 commented Jul 17, 2017

We will be releasing this shortly.

@mjpt777 mjpt777 closed this as completed Jul 17, 2017
@ksergey
Copy link
Contributor Author

ksergey commented Aug 17, 2017

@mjpt777
The same for messages - m_bufferLength should have public getter. Could you please fix?

mjpt777 added a commit that referenced this issue Aug 17, 2017
@mjpt777
[C++] Add an accessor for bufferLength on messages. Issue #479.
2b98dba
@mjpt777
Copy link
Contributor

mjpt777 commented Aug 17, 2017

Done.

@ksergey
Copy link
Contributor Author

ksergey commented Aug 17, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ksergey @mjpt777 @tmontgomery