[Java] sbe 1.16.3 generates noisy Java code

[hrstoyanov]

Please cleanup the SBE generated Java code. Here is SBE-generated snippet of code:

public SetFileAttributesEncoder putPath(final DirectBuffer src, final int srcOffset, final int length)
    {
        if (length > 1073741824)
        {
            throw new IllegalStateException("length > maxValue for type: " + length);
        }

        final int headerLength = 4;
        final int limit = parentMessage.limit();
        parentMessage.limit(limit + headerLength + length);
        buffer.putInt(limit, (int)length, java.nio.ByteOrder.LITTLE_ENDIAN);
        buffer.putBytes(limit + headerLength, src, srcOffset, length);

        return this;
    }

To which the Java compiler says:

..../hasql/message/src/main/java/dynamind/hasql/message/SetFileAttributesEncoder.java:215: warning: [cast] redundant cast to int
        buffer.putInt(limit, (int)length, java.nio.ByteOrder.LITTLE_ENDIAN);

This is very irritating because it is outside the developer's control, pollutes reports and CI builds.

[mjpt777]

We welcome contributions and sponsorship.

[hrstoyanov]

Thanks @mjpt777 , I was gonna pick this change up, but I see you did it already!
Here is the compiler switches I used to generate the warnings:

subprojects {
    apply plugin: 'java'
    sourceCompatibility = JavaVersion.VERSION_14
    targetCompatibility = JavaVersion.VERSION_14
    tasks.withType(JavaCompile) {
        options.incremental = true
        options.encoding = 'UTF-8'
        sourceCompatibility = JavaVersion.VERSION_14
        targetCompatibility = JavaVersion.VERSION_14
        options.compilerArgs  << "-Xlint"<<"-Xlint:-try"
    }
}

Also, while at that pls upgrade Gradle to 6.3

[mjpt777]

Gradle 6.3 is just released. We will upgrade in time. We only take direct action for customers who provide us with commercial support.

[hrstoyanov]

That is fine, but Java 14 requires Gradle 6.3