Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet core support #456

Merged
merged 1 commit into from
May 20, 2017
Merged

dotnet core support #456

merged 1 commit into from
May 20, 2017

Conversation

markmcdowell
Copy link

Update to:

  • build against netstandard 1.3 (lowest version of net standard required)
  • build against net45
  • added csharpbuild.cmd (similar to cppbuild.cmd) to restore, build and run tests
  • corrected nuspec for multiple dotnet versions

@mjpt777
Copy link
Contributor

mjpt777 commented May 19, 2017

Thanks! It would be good to get a review from @odeheurles or @billsegall on this.

@billsegall
Copy link
Contributor

The patch addresses something on the roadmap and I'd love to see it integrated. There are a bunch of improvements here.

I tried the following:
git clone git@github.com:real-logic/simple-binary-encoding.git
cd simple-binary-encoding
git fetch origin pull/456/head:dn
git checkout dn
gradlew
gradlew generatecsharpcodecs
cd csharp
csharpbuild.cmd

The build then proceeds until I see:
error : This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ..\packages\MSTest.TestAdapter.1.1.17\build\net45\MSTest.TestAdapter.props

Once I've opened the solution and built from there then csharpbuild.cmd works.

I think we can accept the PR and look to fix the build script from clean checkout separately.

Bill.

@markmcdowell
Copy link
Author

Let me fix that, it should really work.

@markmcdowell
Copy link
Author

Now builds from clean checkout.

@mjpt777 mjpt777 merged commit 922b4ce into real-logic:master May 20, 2017
@mjpt777
Copy link
Contributor

mjpt777 commented May 20, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants