[Java] Using sinceVersion from field instead of type declaration

[zyulyaev]

Generated if statement in decoder's methods must use sinceVersion from fields declaration, not type declarations.

[zyulyaev]

I also added sinceVersion static methods for composite type members.

[tmontgomery]

The spec states "Message header encoding cannot change."

[tmontgomery]

In general, this looks quite good. Thanks for adding the test!

[tmontgomery]

Should probably remove the extension to the MessageHeader, though.

[mjpt777]

Extending a message header is tricky. The message header itself does not come with its own length fields thus it will break existing code which expects message headers to be constant length. It is a part of the specification I've never been comfortable with. The fact that the schemas cannot cross reference makes this more tricky and the only practical way to do anything cross schema is to relay on fixed message headers and other types like group and var data header encodings.

[zyulyaev]

Okay, I removed message header extension, but I still would like to have sinceVersion methods in composite decoder classes, if it is not a problem.
I also made similar changes to enums and bitsets.
BTW, don't you think that for enum fields it would be better to remove NULL_VAL constant instead of null reference?

[mjpt777]

@zyulyaev The NULL_VAL and SBE_UNKNOWN make it easy to deal with an enum in a switch statement. Without them you could get a NullPointerException.

[zyulyaev]

@mjpt777 Sorry, I meant “return”, not “remove”. And that’s exactly my point. But now generated “if” block returns null reference, not the NULL_VAL for enums.

[mjpt777]

@zyulyaev Yes it would make more sense to return the NULL_VAL from the property getter if not present. Good spot.

[mjpt777]

@zyulyaev I've made a change to return the NULL_VAL like you suggested.

[zyulyaev]

@mjpt777 Great, thank you!