golang: Use pointer receiver where appropriate #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkramer
commented
Jul 31, 2018
lkramer
commented
- In order to avoid copying the whole structure functions should use pointer receiver when possible.
- One exception is for enums, where it makes more sense to keep the copy receivers.
- In order to avoid copying the whole structure functions should use pointer receiver when possible. - One exception is for enums, where it makes more sense to keep the copy receivers.
|
Maybe @billsegall can comment on this? |
|
I'm happy with this. It's 100% compatible and benchmarks faster on Encode. Good stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.