-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C#] Add ToString #853
[C#] Add ToString #853
Conversation
More, hopefully efficient, mechanisms to read and write strings to and from the DirectBuffer.
…hmark which encodes and decodes to/from string; and a version wich uses the new methods to encode and decode strings
case BEGIN_COMPOSITE: | ||
{ | ||
append(sb, indent, "if (this." + fieldName + " != null)"); | ||
append(sb, indent, " this." + fieldName + ".BuildString(builder);"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocks without braces is not good practice and easy to introduce bugs with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I also saw an small indenting issue which I fixed.
Looks good. If you fix the generated code to always put code blocks in curly brackets then I'll merge. |
#852
Example: