grunt doc fails

[jonnenauha]

jsdoc recently made a change that runs the application code with js strict mode. I can't imagine what the reasoning for this might be, forcing non strict code to go this way will create breakages.

I have fixed this in Meshmoon web-rocket already. I would imagine cherry picking it here until we base our impl to this repo will be impossible.

But the fix is to put "use strict"; as the first line inside the define() function in the file its complaining about. Then F5 run client.html and go fix the place, chrome dev tools will give you exact like by clicking the error. Note that not all strict mode errors happen during file parsing. So for some things you actually have to execute the function to get the strict mode error to dev tools.

As said I have gone through the codebase to make jsdoc work, for file parsing and execution. @cvetan5 can go though my commits and port the changes manually.

Finally test with grunt doc that it completes without errors.

[jonnenauha]

Until this is fixed, a temp fix would be to comment out https://github.com/realXtend/WebTundra/blob/master/Gruntfile.js#L754 to make grunt build work again.

I would maybe advice against this as it will then get forgotten :) Also using strict mode in the modules is better. I have started to transition web-rocket to this, but it is a bit hard as a afterthought because its hard to execute all code paths with programmatic testing. Also the fix is not that labor intensive so just same to spend an hour with it :)