Merge pull request 'feat: use medium.com's URL patterns' (#9) from fi… #72
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
1 error and 16 warnings
nightly - x86_64-unknown-linux-gnu
Couldn't find a release tarball containing binaries for latest
|
nightly - x86_64-unknown-linux-gnu
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions-rs/toolchain@v1, actions-rs/tarpaulin@v0.1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
nightly - x86_64-unknown-linux-gnu
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
nightly - x86_64-unknown-linux-gnu
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
nightly - x86_64-unknown-linux-gnu
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
nightly - x86_64-unknown-linux-gnu
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
useless use of `vec!`:
src/proxy.rs#L288
warning: useless use of `vec!`
--> src/proxy.rs:288:20
|
288 | let urls = vec![
| ____________________^
289 | | "/ftrain/big-data-small-effort-b62607a43a8c",
290 | | "/shawn-shi/rest-api-best-practices-decouple-long-running-tasks-from-http-request-processing-9fab2921ace8",
291 | | ];
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
help: you can use an array directly
|
288 ~ let urls = ["/ftrain/big-data-small-effort-b62607a43a8c",
289 ~ "/shawn-shi/rest-api-best-practices-decouple-long-running-tasks-from-http-request-processing-9fab2921ace8"];
|
|
useless use of `vec!`:
src/proxy.rs#L275
warning: useless use of `vec!`
--> src/proxy.rs:275:20
|
275 | let urls = vec![
| ____________________^
276 | | "/@ftrain/big-data-small-effort-b62607a43a8c",
277 | | "/@shawn-shi/rest-api-best-practices-decouple-long-running-tasks-from-http-request-processing-9fab2921ace8",
278 | | "/",
279 | | "/asset/medium/1*LY2ohYsNa9nOV1Clko3zJA.png",
280 | | ];
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: `#[warn(clippy::useless_vec)]` on by default
help: you can use an array directly
|
275 ~ let urls = ["/@ftrain/big-data-small-effort-b62607a43a8c",
276 + "/@shawn-shi/rest-api-best-practices-decouple-long-running-tasks-from-http-request-processing-9fab2921ace8",
277 + "/",
278 ~ "/asset/medium/1*LY2ohYsNa9nOV1Clko3zJA.png"];
|
|
accessing first element with `splits.get(0)`:
src/data.rs#L195
warning: accessing first element with `splits.get(0)`
--> src/data.rs:195:13
|
195 | splits.get(0).unwrap()
| ^^^^^^^^^^^^^ help: try: `splits.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
|
fields `p` and `gists` are never read:
src/post.rs#L37
warning: fields `p` and `gists` are never read
--> src/post.rs:37:5
|
35 | struct Markup<'a, 'b> {
| ------ fields in this struct
36 | markup: &'a GetPostPostContentBodyModelParagraphsMarkups,
37 | p: &'a GetPostPostContentBodyModelParagraphs,
| ^
38 | pos_type: PostitionType,
39 | gists: &'b Option<Vec<(String, crate::data::GistContent)>>,
| ^^^^^
|
field `cache` is never read:
src/data.rs#L36
warning: field `cache` is never read
--> src/data.rs:36:5
|
34 | pub struct Data {
| ---- field in this struct
35 | pub client: Client,
36 | cache: Db,
| ^^^^^
|
= note: `Data` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
variable does not need to be mutable:
/home/runner/work/libmedium/libmedium/target/debug/build/sailfish-compiler-20ab31de03018ef6/out/templates/post-7ba4236f6581f537#L62
warning: variable does not need to be mutable
--> /home/runner/work/libmedium/libmedium/target/debug/build/sailfish-compiler-20ab31de03018ef6/out/templates/post-7ba4236f6581f537:62:9
|
62 | let mut open_list = false;
| ----^^^^^^^^^
| |
| help: remove this `mut`
|
unused variable: `open_list`:
/home/runner/work/libmedium/libmedium/target/debug/build/sailfish-compiler-20ab31de03018ef6/out/templates/post-7ba4236f6581f537#L62
warning: unused variable: `open_list`
--> /home/runner/work/libmedium/libmedium/target/debug/build/sailfish-compiler-20ab31de03018ef6/out/templates/post-7ba4236f6581f537:62:13
|
62 | let mut open_list = false;
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_open_list`
|
unused variable: `gists`:
src/proxy.rs#L126
warning: unused variable: `gists`
--> src/proxy.rs:126:9
|
126 | pub gists: Option<Vec<(String, crate::data::GistContent)>>,
| ^^^^^ help: try ignoring the field: `gists: _`
|
unused variable: `id`:
src/proxy.rs#L125
warning: unused variable: `id`
--> src/proxy.rs:125:9
|
125 | pub id: String,
| ^^ help: try ignoring the field: `id: _`
|
= note: `#[warn(unused_variables)]` on by default
|
use of deprecated method `chrono::TimeZone::timestamp_millis`: use `timestamp_millis_opt()` instead:
src/proxy.rs#L225
warning: use of deprecated method `chrono::TimeZone::timestamp_millis`: use `timestamp_millis_opt()` instead
--> src/proxy.rs:225:10
|
225 | .timestamp_millis(post_data.created_at)
| ^^^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
variable does not need to be mutable:
src/data.rs#L203
warning: variable does not need to be mutable
--> src/data.rs:203:13
|
203 | let mut id = Self::get_gist_id(&gist_url).to_owned();
| ----^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|