Do not trigger return_value_from_void_function in initializers (#5429)

realm · Jan 19, 2024 · 2b6e0ee · 2b6e0ee
1 parent fc2a18e
commit 2b6e0ee
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -134,6 +134,9 @@
   [SimplyDanny](https://github.com/SimplyDanny)
   [#3852](https://github.com/realm/SwiftLint/pull/3852)
 
+* Don't trigger the `return_value_from_void_function` warning from initializers.  
+  [mrbkap](https://github.com/mrbkap)
+
 ## 0.54.0: Macro-Economic Forces
 
 #### Breaking

diff --git a/Source/SwiftLintBuiltInRules/Rules/Idiomatic/ReturnValueFromVoidFunctionRule.swift b/Source/SwiftLintBuiltInRules/Rules/Idiomatic/ReturnValueFromVoidFunctionRule.swift
@@ -57,7 +57,7 @@ private extension Syntax {
             return node
         }
 
-        if self.is(ClosureExprSyntax.self) || self.is(VariableDeclSyntax.self) {
+        if self.is(ClosureExprSyntax.self) || self.is(VariableDeclSyntax.self) || self.is(InitializerDeclSyntax.self) {
             return nil
         }
 

diff --git a/Source/SwiftLintBuiltInRules/Rules/Idiomatic/ReturnValueFromVoidFunctionRuleExamples.swift b/Source/SwiftLintBuiltInRules/Rules/Idiomatic/ReturnValueFromVoidFunctionRuleExamples.swift
@@ -45,6 +45,17 @@ internal struct ReturnValueFromVoidFunctionRuleExamples {
         }
         """),
         Example("""
+        func baz() {
+            enum Foo {
+                case bar
+
+                init?(arg: String?) {
+                    return nil
+                }
+            }
+        }
+        """, excludeFromDocumentation: true),
+        Example("""
         func test() {
             guard condition else {
                 return