Merge pull request #2430 from biboran/empty-count-fix

#2423 - Fix EmptyCountRule for binary, octal and hexadecimal integer literals

CHANGELOG.md

@@ -101,6 +101,11 @@
   [Ornithologist Coder](https://github.com/ornithocoder)
   [#2374](https://github.com/realm/SwiftLint/issues/2374)
 
+* Fix false positive on `empty_count` rule when assesing binary, octal and
+  hexadecimal integer literals.  
+  [Timofey Solonin](https://github.com/biboran)
+  [#2423](https://github.com/realm/SwiftLint/issues/2423)
+
 ## 0.27.0: Heavy Duty
 
 #### Breaking

Rules.md

@@ -4712,6 +4712,21 @@ var count = 0
 
 ```
 
+```swift
+[Int]().count == 0xff
+
+```
+
+```swift
+[Int]().count == 0b01
+
+```
+
+```swift
+[Int]().count == 0o07
+
+```
+
 ```swift
 discount == 0
 
@@ -4741,6 +4756,26 @@ order.discount == 0
 
 ```
 
+```swift
+[Int]().↓count == 0x0
+
+```
+
+```swift
+[Int]().↓count == 0x00_00
+
+```
+
+```swift
+[Int]().↓count == 0b00
+
+```
+
+```swift
+[Int]().↓count == 0o00
+
+```
+
 ```swift
 ↓count == 0
 

Source/SwiftLintFramework/Rules/Performance/EmptyCountRule.swift

@@ -15,19 +15,26 @@ public struct EmptyCountRule: ConfigurationProviderRule, OptInRule, AutomaticTes
             "[Int]().isEmpty\n",
             "[Int]().count > 1\n",
             "[Int]().count == 1\n",
+            "[Int]().count == 0xff\n",
+            "[Int]().count == 0b01\n",
+            "[Int]().count == 0o07\n",
             "discount == 0\n",
             "order.discount == 0\n"
         ],
         triggeringExamples: [
             "[Int]().↓count == 0\n",
             "[Int]().↓count > 0\n",
             "[Int]().↓count != 0\n",
+            "[Int]().↓count == 0x0\n",
+            "[Int]().↓count == 0x00_00\n",
+            "[Int]().↓count == 0b00\n",
+            "[Int]().↓count == 0o00\n",
             "↓count == 0\n"
         ]
     )
 
     public func validate(file: File) -> [StyleViolation] {
-        let pattern = "\\bcount\\s*(==|!=|<|<=|>|>=)\\s*0"
+        let pattern = "\\bcount\\s*(==|!=|<|<=|>|>=)\\s*0(\\b|([box][0_]+\\b){1})"
         let excludingKinds = SyntaxKind.commentAndStringKinds
         return file.match(pattern: pattern, excludingSyntaxKinds: excludingKinds).map {
             StyleViolation(ruleDescription: type(of: self).description,