Skip to content

Commit

Permalink
Switched to structs so we can test for uniqueness, as tuples cannot b…
Browse files Browse the repository at this point in the history 
…e Equatable yet, despite SE-0283
  • Loading branch information
@mildm8nnered
mildm8nnered committed Jul 16, 2023
1 parent da99b93 commit 6f3ef9c
Showing 1 changed file with 51 additions and 48 deletions.
99 changes: 51 additions & 48 deletions Tests/SwiftLintFrameworkTests/ConfigurationTests+MultipleConfigs.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -302,33 +302,34 @@ extension ConfigurationTests {
}

func testParentChildOptInAndDisable() {
// swiftlint:disable:next large_tuple
typealias TestCase = (
optedInInParent: Bool,
disabledInParent: Bool,
optedInInChild: Bool,
disabledInChild: Bool,
isEnabled: Bool
)
struct TestCase: Equatable {
let optedInInParent: Bool
let disabledInParent: Bool
let optedInInChild: Bool
let disabledInChild: Bool
let isEnabled: Bool
}
let testCases: [TestCase] = [
(false, false, false, false, false),
(true, false, false, false, true),
(false, true, false, false, false),
(true, true, false, false, false),
(false, false, true, false, true),
(true, false, true, false, true),
(false, true, true, false, true),
(true, true, true, false, true),
(false, false, false, true, false),
(true, false, false, true, false),
(false, true, false, true, false),
(true, true, false, true, false),
(false, false, true, true, false),
(true, false, true, true, false),
(false, true, true, true, false),
(true, true, true, true, false)
// swiftlint:disable line_length
TestCase(optedInInParent: false, disabledInParent: false, optedInInChild: false, disabledInChild: false, isEnabled: false),
TestCase(optedInInParent: true, disabledInParent: false, optedInInChild: false, disabledInChild: false, isEnabled: true),
TestCase(optedInInParent: false, disabledInParent: true, optedInInChild: false, disabledInChild: false, isEnabled: false),
TestCase(optedInInParent: true, disabledInParent: true, optedInInChild: false, disabledInChild: false, isEnabled: false),
TestCase(optedInInParent: false, disabledInParent: false, optedInInChild: true, disabledInChild: false, isEnabled: true),
TestCase(optedInInParent: true, disabledInParent: false, optedInInChild: true, disabledInChild: false, isEnabled: true),
TestCase(optedInInParent: false, disabledInParent: true, optedInInChild: true, disabledInChild: false, isEnabled: true),
TestCase(optedInInParent: true, disabledInParent: true, optedInInChild: true, disabledInChild: false, isEnabled: true),
TestCase(optedInInParent: false, disabledInParent: false, optedInInChild: false, disabledInChild: true, isEnabled: false),
TestCase(optedInInParent: true, disabledInParent: false, optedInInChild: false, disabledInChild: true, isEnabled: false),
TestCase(optedInInParent: false, disabledInParent: true, optedInInChild: false, disabledInChild: true, isEnabled: false),
TestCase(optedInInParent: true, disabledInParent: true, optedInInChild: false, disabledInChild: true, isEnabled: false),
TestCase(optedInInParent: false, disabledInParent: false, optedInInChild: true, disabledInChild: true, isEnabled: false),
TestCase(optedInInParent: true, disabledInParent: false, optedInInChild: true, disabledInChild: true, isEnabled: false),
TestCase(optedInInParent: false, disabledInParent: true, optedInInChild: true, disabledInChild: true, isEnabled: false),
TestCase(optedInInParent: true, disabledInParent: true, optedInInChild: true, disabledInChild: true, isEnabled: false)
// swiftlint:enable line_length
]
XCTAssertEqual(testCases.count, 4 * 4)
XCTAssertEqual(testCases.unique.count, 4 * 4)
let ruleType = ImplicitReturnRule.self
let ruleIdentifier = ruleType.description.identifier
for testCase in testCases {
Expand All @@ -350,18 +351,18 @@ extension ConfigurationTests {
}

func testParentChildDisableForDefaultRule() {
typealias TestCase = (
disabledInParent: Bool,
disabledInChild: Bool,
isEnabled: Bool
)
struct TestCase: Equatable {
let disabledInParent: Bool
let disabledInChild: Bool
let isEnabled: Bool
}
let testCases: [TestCase] = [
(false, false, true),
(true, false, false),
(false, true, false),
(true, true, false)
TestCase(disabledInParent: false, disabledInChild: false, isEnabled: true),
TestCase(disabledInParent: true, disabledInChild: false, isEnabled: false),
TestCase(disabledInParent: false, disabledInChild: true, isEnabled: false),
TestCase(disabledInParent: true, disabledInChild: true, isEnabled: false)
]
XCTAssertEqual(testCases.count, 2 * 2)
XCTAssertEqual(testCases.unique.count, 2 * 2)
let ruleType = BlanketDisableCommandRule.self
let ruleIdentifier = ruleType.description.identifier
for testCase in testCases {
Expand All @@ -379,19 +380,20 @@ extension ConfigurationTests {
}
}

private typealias OptedInAndDisabledInChildTestCase = (
optedInInChild: Bool,
disabledInChild: Bool,
isEnabled: Bool
)
private struct OptedInAndDisabledInChildTestCase: Equatable {
let optedInInChild: Bool
let disabledInChild: Bool
let isEnabled: Bool
}

func testParentOnlyRulesAndChildOptInAndDisabled() {
let testCases: [OptedInAndDisabledInChildTestCase] = [
(false, false, true),
(true, false, true),
(false, true, false),
(true, true, false)
OptedInAndDisabledInChildTestCase(optedInInChild: false, disabledInChild: false, isEnabled: true),
OptedInAndDisabledInChildTestCase(optedInInChild: true, disabledInChild: false, isEnabled: true),
OptedInAndDisabledInChildTestCase(optedInInChild: false, disabledInChild: true, isEnabled: false),
OptedInAndDisabledInChildTestCase(optedInInChild: true, disabledInChild: true, isEnabled: false)
]
XCTAssertEqual(testCases.unique.count, 2 * 2)
let ruleType = ImplicitReturnRule.self
let parentConfiguration = Configuration(rulesMode: .only([ruleType.description.identifier]))
testParentConfigurationAndChildOptInAndDisabled(
Expand All @@ -401,11 +403,12 @@ extension ConfigurationTests {

func testParentAllRulesAndChildOptInAndDisabled() {
let testCases: [OptedInAndDisabledInChildTestCase] = [
(false, false, true),
(true, false, true),
(false, true, false),
(true, true, false)
OptedInAndDisabledInChildTestCase(optedInInChild: false, disabledInChild: false, isEnabled: true),
OptedInAndDisabledInChildTestCase(optedInInChild: true, disabledInChild: false, isEnabled: true),
OptedInAndDisabledInChildTestCase(optedInInChild: false, disabledInChild: true, isEnabled: false),
OptedInAndDisabledInChildTestCase(optedInInChild: true, disabledInChild: true, isEnabled: false)
]
XCTAssertEqual(testCases.unique.count, 2 * 2)
let ruleType = ImplicitReturnRule.self
let parentConfiguration = Configuration(rulesMode: .allEnabled)
testParentConfigurationAndChildOptInAndDisabled(
Expand Down

0 comments on commit 6f3ef9c

Please sign in to comment.