Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompilerProtocolInitRule lacks dynamic description #2422

Closed
2 tasks done
abdulowork opened this issue Sep 27, 2018 · 3 comments
Closed
2 tasks done

CompilerProtocolInitRule lacks dynamic description #2422

abdulowork opened this issue Sep 27, 2018 · 3 comments
Labels
enhancement Ideas for improvements of existing features and rules.

Comments

@abdulowork
Copy link
Contributor

New Issue Checklist

Describe the bug

CompilerProtocolInitRule description may be needlessly difficult to understand because it has a static description. It can be improved upon by stating which literal rule was violated.

Complete output when running SwiftLint, including the stack trace and command used

n/a

Environment

  • SwiftLint version (run swiftlint version to be sure)?: 0.27.0
@realm-probot realm-probot bot added the O:User label Sep 27, 2018
@marcelofabri marcelofabri added the enhancement Ideas for improvements of existing features and rules. label Sep 27, 2018
@marcelofabri
Copy link
Collaborator

@Biboran wanna try to send a PR with this enhancement?

@abdulowork
Copy link
Contributor Author

@marcelofabri sure

abdulowork pushed a commit to abdulowork/SwiftLint that referenced this issue Oct 1, 2018
realm#2422 - Specify which compiler protocol initialization rule was …
5bf50c8 
…violated
abdulowork pushed a commit to abdulowork/SwiftLint that referenced this issue Oct 1, 2018
realm#2422 - Add CompilerProtocolInitRule violation unit test for Exp…
2cc4dca 
…ressibleByIntegerLiteral protocol
@abdulowork abdulowork mentioned this issue Oct 1, 2018
Merged
abdulowork pushed a commit to abdulowork/SwiftLint that referenced this issue Oct 1, 2018
realm#2422 - Fix CI
3189d17
abdulowork pushed a commit to abdulowork/SwiftLint that referenced this issue Oct 1, 2018
realm#2422 - Replace ruleDescription change with a StyleViolation rea…
22be71e 
…son field in CompilerProtocolInitRule
abdulowork pushed a commit to abdulowork/SwiftLint that referenced this issue Oct 1, 2018
realm#2422 - Add changelog entry
78ebad7
abdulowork pushed a commit to abdulowork/SwiftLint that referenced this issue Oct 1, 2018
realm#2422 - Fix changelog
1b71ae7
marcelofabri added a commit that referenced this issue Oct 2, 2018
@marcelofabri
Merge pull request #2428 from biboran/compiler-protocol-init-description
5bcaa61 
#2422 - Specify which literal rule was violated for CompilerProtocolInitRule
@marcelofabri
Copy link
Collaborator

Implemented in #2488 🎉

sjavora pushed a commit to sjavora/SwiftLint that referenced this issue Mar 9, 2019
@sjavora
realm#2422 - Specify which compiler protocol initialization rule was …
82414db 
…violated
sjavora pushed a commit to sjavora/SwiftLint that referenced this issue Mar 9, 2019
@sjavora
realm#2422 - Add CompilerProtocolInitRule violation unit test for Exp…
1a130d1 
…ressibleByIntegerLiteral protocol
sjavora pushed a commit to sjavora/SwiftLint that referenced this issue Mar 9, 2019
@sjavora
realm#2422 - Fix CI
f6ba18a
sjavora pushed a commit to sjavora/SwiftLint that referenced this issue Mar 9, 2019
@sjavora
realm#2422 - Replace ruleDescription change with a StyleViolation rea…
042bfba 
…son field in CompilerProtocolInitRule
sjavora pushed a commit to sjavora/SwiftLint that referenced this issue Mar 9, 2019
@sjavora
realm#2422 - Add changelog entry
9fd0d18
sjavora pushed a commit to sjavora/SwiftLint that referenced this issue Mar 9, 2019
@sjavora
realm#2422 - Fix changelog
0121f0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Ideas for improvements of existing features and rules.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcelofabri @abdulowork