-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no_magic_numbers
rule should ignore 100
#5215
Merged
SimplyDanny
merged 2 commits into
realm:main
from
mildm8nnered:mildm8nnered-100-is-not-magic
Sep 11, 2023
Merged
no_magic_numbers
rule should ignore 100
#5215
SimplyDanny
merged 2 commits into
realm:main
from
mildm8nnered:mildm8nnered-100-is-not-magic
Sep 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimplyDanny
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
no_magic_numbers
rule now ignores 100I didn't go for any power of 10, as 100 is 97% plus of the cases in one of my large codebases (100 = 4,000+ [includes user readable strings with 14 languages, which bumps it up a fair bit, but still indicative], 1,000 = 94, 10,000 = 12, 100,000 = 10, 1000,000 = 4).
Resolves #5185